[doc][kuberay] add version skew warning for plugin and RayCluster #53950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain plugin commands since 1.4.0 aren't compatible out-of-the-box with RayCluster Kubernetes Custom Resource Definition from KubeRay before 1.4.0. Signed-off-by: David Xia <david@davidxia.com>
kevin85421
approved these changes
Jun 19, 2025
|
Please ping me when all CI tests pass. Thank you! |
|
cc @dayshah would you mind stamping this PR? Thanks! |
dayshah
reviewed
Jun 26, 2025
|
cc @dayshah I can see the change: |
oh maybe i was looking in the wrong spot mb |
dayshah
reviewed
Jun 26, 2025
Comment on lines
+16
to
+19
| ```{admonition} Plugin after 1.4.0 may be incompatible with RayCluster before 1.4.0 | ||
| :class: warning | ||
| Certain plugin commands since 1.4.0 aren't compatible out-of-the-box with RayCluster Kubernetes | ||
| Custom Resource Definition from KubeRay before 1.4.0. |
There was a problem hiding this comment.
this warning sounds a bit confusing because of the mix up between RayCluster RayCluster CRD and KubeRay. It's basically just trying to say that commands that work with KubeRay 1.4.0 are not guaranteed to work with previous KubeRay versions right. Can you simplify the wording a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain plugin commands since 1.4.0 aren't compatible out-of-the-box with RayCluster Kubernetes Custom Resource Definition from KubeRay before 1.4.0.