[core] Revert container tests to medium size instance #53966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dayshah <dhyey2019@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR reverts container tests to run on medium instance types to restore compatibility caused by a docker version mismatch on large instances.
- Instance type changed from "large" to "medium" to address issues with new docker versions on large instances.
israbbani
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Talked to @khluu about downgrading docker. In the meantime, just moving this back to medium so at least the tests start passing and it's no longer a release blocker.
How come the tests pass now on the medium size instance?
diff docker version 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently these container tests fail after #53783. This is because the docker version on the large instance containers is new and incompatible with the old podman version installed by default with apt-get. Moving it back to the medium instances fixes this because of the older docker version.
Installing a newer podman on ubuntu seems non-trivial and still deciding between upgrading podman or downgrading docker on the large instance containers.
Talked to @khluu about downgrading docker. In the meantime, just moving this back to medium so at least the tests start passing and it's no longer a release blocker.
Related issue number
#45223
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.