[Data] Fixing PyArrow overflow handling #53971
Merged
+122
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinathk10
reviewed
Jun 25, 2025
| # Remaining 2 go into the second one | ||
| assert result.chunks[1].nbytes == sum([c.nbytes for c in input_.chunks[14:]]) | ||
|
|
||
| @pytest.mark.parametrize( |
| @@ -361,8 +362,9 @@ def test_combine_chunked_array_small( | |||
| expected_output.equals(result) | |||
|
|
|||
|
|
|||
| def test_combine_chunked_array_large(): | |||
| """Verifies `combine_chunked_array` on arrays > 2 GiB""" | |||
| def test_combine_chunked_fixed_width_array_large(): | |||
There was a problem hiding this comment.
Will go good to add coverage for all _VARIABLE_WIDTH_INT32_OFFSET_PA_TYPE_PREDICATES
There was a problem hiding this comment.
It does below (this is for fixed-width types)
raulchen
reviewed
Jun 25, 2025
…32 offsets overflows (irrelevant for fixed-width arrays) Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
ced6071 to
5945253
Compare
6 tasks
Updated description, that should hopefully answer that question, LMK |
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
raulchen
approved these changes
Jun 26, 2025
minerharry
pushed a commit
to minerharry/ray
that referenced
this pull request
Jun 27, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? Current int32 offsets overflow handling is missing appropriate handling of the fixed-width types (any types not involving arbitrary length types like strings, lists, binary, etc). As a result this has been incorrectly enforcing the 2Gb limit on blocks that actually don't have that limit. This PR addresses that. Changes 1. Make sure overflow handling only applied to variable-width types 2. Fixed chunking method to prevent adding empty chunks 3. Updated tests ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: Alexey Kudinkin <ak@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Current int32 offsets overflow handling is missing appropriate handling of the fixed-width types (any types not involving arbitrary length types like strings, lists, binary, etc).
As a result this has been incorrectly enforcing the 2Gb limit on blocks that actually don't have that limit. This PR addresses that.
Changes
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.