8000 refactor: improve coverage to 95% by mabdh · Pull Request #118 · raystack/siren · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: improve coverage to 95% #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2022
Merged

refactor: improve coverage to 95% #118

merged 1 commit into from
Jul 19, 2022

Conversation

mabdh
Copy link
Member
@mabdh mabdh commented Jul 19, 2022

No description provided.

@mabdh mabdh requested a review from rahmatrhd July 19, 2022 04:04
@mabdh mabdh linked an issue Jul 19, 2022 that may be closed by this pull request
8000 Increase coverage to 95% #111
Closed
@mabdh mabdh requested a review from ravisuhag July 19, 2022 04:05
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2695065755

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 95.447%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/rule/service.go 3 5 60.0%
Totals Coverage Status
Change from base Build 2694807352: 2.3%
Covered Lines: 2243
Relevant Lines: 2350
💛 - Coveralls

@ravisuhag ravisuhag merged commit 837bff1 into main Jul 19, 2022
@ravisuhag ravisuhag deleted the improve-coverage-95% branch July 19, 2022 04:51
ravisuhag pushed a commit that referenced this pull request Aug 21, 2022
@mabdh
refactor: improve coverage to 95% (#118)
10c9ed6
ravisuhag pushed a commit that referenced this pull request Aug 21, 2022
@mabdh
refactor: improve coverage to 95% (#118)
226671b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase coverage to 95%
3 participants
@mabdh @coveralls @ravisuhag
0