feat: add validation support using go-grpc-middleware #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor - UpdateRule, GetTemplateByName & UpsertTemplate response
rohilsurana
approved these changes
Sep 6, 2021
9fc1cb7 to
6234803
Compare
|
@rohilsurana updated some validation. can you have a look again |
rohilsurana
reviewed
Sep 8, 2021
| @@ -26,4 +26,5 @@ bin/air | |||
| tmp | |||
| dist/ | |||
| siren | |||
| !siren/ | |||
There was a problem hiding this comment.
We need to ignore siren executable file but siren exclude all nested folder with siren name. In order to prevent that we need to specify this
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
* feat: add validation support using go-grpc-middleware refactor - UpdateRule, GetTemplateByName & UpsertTemplate response * doc: update swagger file * refactor: change name from pb to sirenv1 for versioned proto * chore: add validate plugin in buf file
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
* feat: add validation support using go-grpc-middleware refactor - UpdateRule, GetTemplateByName & UpsertTemplate response * doc: update swagger file * refactor: change name from pb to sirenv1 for versioned proto * chore: add validate plugin in buf file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor - UpdateRule, GetTemplateByName & UpsertTemplate response