refactor: namespace repository, handle encryption in service #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravisuhag
reviewed
Mar 11, 2022
ravisuhag
reviewed
Mar 11, 2022
|
The POST namespace API is not returning the id in the response payload. |
|
There is test coverage missing on encrypt/decrypt function in the namespace service. Let's not miss coverage on core business logic. |
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
* refactor: refactor namespace repository, handle encryption in service * test: fix namespace service & repository tests * refactor: change create and update methods to pass parameter by reference * chore: fix test coverage make command * chore: remove accidentally generated mock file * fix(namespace): return newly created ID on create namespace * test(namespace): test encryption transformer * fix(namespace): return full values once updated * chore(namespace): remove unnecessary logging
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
* refactor: refactor namespace repository, handle encryption in service * test: fix namespace service & repository tests * refactor: change create and update methods to pass parameter by reference * chore: fix test coverage make command * chore: remove accidentally generated mock file * fix(namespace): return newly created ID on create namespace * test(namespace): test encryption transformer * fix(namespace): return full values once updated * chore(namespace): remove unnecessary logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.