Feat: Borsh deser using unsafe #417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous implementation was bugged
5cbbd58 to
db4fc43
Compare
3 tasks
|
This works very nicely! I even used my modified tests (with 240 and 224 bits) and those work as well. I like this solution a lot better. Thank you for spending time on reworking this. |
<
8000
div class="pr-review-reactions ">
|
thanks, I will push my commits to your branch and get this merged shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #416
Motivation
Make a generic implementation of borsh deser without using macros.
PR Checklist