8000
docs: update
DaniPopes
force-pushed
the
usurp-prestwich/remove-len-check
branch
from
February 27, 2025 13:24
DaniPopes
changed the title
fix: remove len check in try_from_be_slice
docs: update Feb 27, 2025
docs: update try_from_{b,l}e_slice docs
#439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prestwich should this be done in _le too? |
yes, let's make the behavior match |
3 tasks
518b198 to
4d9bf3b
Compare
|
Actually the check is necessary otherwise the test I added panics. The behavior wrt leading zeros was incorrect prior to #329 (the index is incremented even if 0s are skipped, so not really ignored) and was removed, so I'm just updating the documentation here. |
try_from_{b,l}e_slice docs
prestwich
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-open #436
Closes #435