8000 feat: constify mul* by DaniPopes · Pull Request #449 · recmo/uint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: constify mul* #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: constify mul* #449

wants to merge 1 commit into from

Conversation

DaniPopes
Copy link
Contributor
@DaniPopes DaniPopes commented Mar 5, 2025 •
edited
Loading

Requires bumping MSRV to 1.83

@DaniPopes DaniPopes force-pushed the const-mul branch 6 times, most recently from fcd5e01 to d2f3ad5 Compare May 21, 2025 21:01
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #449 will degrade performances by 19.02%

Comparing DaniPopes:const-mul (69efe71) with main (51f9ce6)

Summary

⚡ 2 improvements
❌ 5 regressions
✅ 246 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ log/128 8.8 ms 7.7 ms +13.34%
❌ log/192 11.8 ms 13.4 ms -12.25%
⚡ overflowing_pow/128 535 µs 462.9 µs +15.58%
❌ overflowing_pow/192 1.1 ms 1.4 ms -19.02%
❌ overflowing_pow/256 2 ms 2.3 ms -14.8%
❌ overflowing_pow/384 4.5 ms 5.1 ms -11.86%
❌ root/127/192/192 16.1 ms 18.4 ms -12.71%

@DaniPopes DaniPopes force-pushed the const-mul branch 4 times, most recently from 6584e7b to b93330c Compare May 29, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich Awaiting requested review from prestwich prestwich will be requested when the pull request is marked ready for review prestwich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DaniPopes
0