8000 fix: check limb overflow in shift ops by DaniPopes · Pull Request #476 · recmo/uint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: check limb overflow in shift ops #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2025
Merged

fix: check limb overflow in shift ops #476

merged 2 commits into from
May 29, 2025

Conversation

DaniPopes
Copy link
Contributor

Return overflow if the uint is bigger than a u64.

@DaniPopes DaniPopes requested a review from prestwich as a code owner May 29, 2025 01:03
@DaniPopes DaniPopes mentioned this pull request May 29, 2025
Draft
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #476 will degrade performances by 97.95%

Comparing DaniPopes:sh-ops-fix (11e16e2) with main (8a0613d)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 225 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ overflowing_shl 999.1 µs 565.7 µs +76.61%
❌ overflowing_shr 588.6 µs 7,430.7 µs -92.08%
⚡ wrapping_shl 6,730 µs 928.2 µs ×7.3
❌ wrapping_shr 140.1 µs 6,839.9 µs -97.95%

prestwich
prestwich reviewed May 29, 2025
View reviewed changes
@DaniPopes
fix: check limb overflow in shift ops
962c4ac 
Return overflow if the uint is bigger than a u64.
@prestwich prestwich enabled auto-merge May 29, 2025 13:46
@prestwich prestwich merged commit cb6ad05 into recmo:main May 29, 2025
18 checks passed
@DaniPopes DaniPopes deleted the sh-ops-fix branch May 29, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich
0