feat: add rkyv support via derive #484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caac589 to
34c183f
Compare
prestwich
reviewed
Jun 10, 2025
| @@ -148,6 +149,10 @@ pub mod nightly { | |||
| /// | |||
| /// [std-overflow]: https://doc.rust-lang.org/reference/expressions/operator-expr.html#overflow | |||
| #[derive(Clone, Copy, Eq, PartialEq, Hash)] | |||
| #[cfg_attr( | |||
| feature = "rkyv", | |||
| derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize), | |||
There was a problem hiding this comment.
my understanding is that this would serialize extra bytes when the BITS % 64 != 0 because it will serialize the entire array regardless, yes?
There was a problem hiding this comment.
yes, it serialize [u64; LIMBS] regardless of the BITS by the nature of rkyv
There was a problem hiding this comment.
#483 behaves this way as well? wouldn't it be desirable to instead cast to a [u8] of the appropriate size to avoid extra 0-bytes?
There was a problem hiding this comment.
not sure if it's a good idea.
There was a problem hiding this comment.
why is that? seems like a minimal encoding would be desirable?
|
closing this as #483 is preferred |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #483