8000 feat: support for `bigdecimal` crate by klkvr · Pull Request #486 · recmo/uint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support for bigdecimal crate #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

klkvr
Copy link
@klkvr klkvr commented Jun 26, 2025

Motivation

Adds support for conversions from and to bigdecimal::BigDecimal type

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@klkvr klkvr requested a review from prestwich as a code owner June 26, 2025 12:20
Copy link
Collaborator
@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • needs Changelog
  • needs motivation in PR description

@@ -48,6 +48,7 @@ alloy-rlp = { version = "0.3", optional = true, default-features = false }
arbitrary = { version = "1", optional = true, default-features = false }
ark-ff-03 = { version = "0.3.0", package = "ark-ff", optional = true, default-features = false }
ark-ff-04 = { version = "0.4.0", package = "ark-ff", optional = true, default-features = false }
bigdecimal = { version = "0.4", optional = true, default-features = false }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a feature description in the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0