8000 Add Chinese translation by brendan-lee · Pull Request #106 · recogito/recogito-client-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Chinese translation #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Conversation

brendan-lee
Copy link
Contributor

Simplified Chinese and Traditional Chinese

Simplified Chinese and Traditional Chinese
@brendan-lee
Copy link
Contributor Author

Sorry for not following your naming rules, but there are actually two variants of Chinese characters, zh-CN for Simplified Chinese and zh-TW for Traditional Chinese ;-)

@rsimon
Copy link
Member
rsimon commented Jul 23, 2022

That's excellent, thanks so much! I must admit: at the moment my code isn't able to handle subvariants. But that's probably not a big thing. I'll see that I'll add that ASAP for the next release.

@rsimon rsimon merged commit e7d7cd1 into recogito:main Jul 23, 2022
@rsimon
Copy link
Member
rsimon commented Jul 23, 2022

Wait - turns out that language variants are properly handled by RecogitoJS/Annotorious after all. We're all good :-)

Your translations will go live with the next release - thanks again for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0