Nest the wrapper in the body instead of around it #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the body tag instead of around it.
|
Thanks - that's a really useful extension! |
|
Just had a thought this is going to break existing pre-annotations if generated with document.body before the change? Doesn't affect me, but wanted to bring up the possible issue. |
|
That's true. However, RecogitoJS would have introduced a broken DOM structure (by wrapping the body) previously. So I think it's justifiable to introduce this as a (potentially) breaking change. I'll make a note in the next release notes, and will make it the 1.8 release (rather than 1.7.2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if passed in element is the body tag. Place the wrapper inside the body tag instead of around it.