fix(snakemake): update Snakemake to 9.1.0 and snakemake-storage-plug… #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-xrootd to 0.4.1 for Python >=3.11 - Update Snakemake to 9.1.0 for Python >=3.11 to remove the unmaintained datrie dependency, fixing installation issues with modern GCC. - Update snakemake-storage-plugin-xrootd to 0.4.1 for compatibility with Snakemake 9.x. - Keep Snakemake 7.32.4 and pulp for Python <3.11 for backward compatibility. - All tests pass locally (`186 passed, 4 xfailed`), matching CI results. References: - pytries/datrie#101 - pytries/datrie#99 - snakemake/snakemake#3176 - snakemake/snakemake#3105 - snakemake/snakemake#2970 - https://github.com/snakemake/snakemake/releases/tag/v8.29.1 Closes reanahub#494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Snakemake and snakemake-storage-plugin-xrootd dependencies in
reana-commonsto resolve installation issues caused by the unmaintaineddatrielibrary on modern Linux systems (GCC >=14).Closes #494.
Problem
reana-clientor any component depending onreana-commons[snakemake]fails on modern Linux distributions due to compilation errors in thedatriedependency.datrieis unmaintained (pytries/datrie#101), and although a fix exists (pytries/datrie#99), it has not been merged.datriedependency in snakemake/snakemake#3176, available since v8.29.1.Solution
9.1.0(used in snakemake-storage-plugin-xrootd) for Python >=3.11 to remove thedatriedependency.snakemake-storage-plugin-xrootdto0.4.1for compatibility with Snakemake 9.1.0.Testing
reana-commonstests pass locally:reana-clientand ran all tests:roofitexample from reanahub: finished successfully.References
Impact
This PR fix the installation of any component depending on
reana-commons[snakemake]on modern Linux distributions and affects reproducibility and maintainability for new users and contributors.This will fix the reana-client installing error
Let me know if I'm wrong, clarify any detail or if more tests are needed.
Closes #494