update destroyTooltipOnHide to destroyOnHidden #495
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
""" Walkthrough本次变更主要包括对 Tooltip 组件及其相关示例的类型注解优化、属性命名统一（ Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Tooltip
participant Trigger
participant Popup
User->>Tooltip: 传递 destroyOnHidden 属性
Tooltip->>Trigger: 传递 autoDestroy={destroyOnHidden}
Trigger->>Popup: 控制弹层显示/销毁
User->>Tooltip: 触发 onOpenChange/afterOpenChange 事件
Tooltip->>Trigger: 事件重命名同步传递
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 33 33
Branches 12 12
=========================================
Hits 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
.github/workflows/site-deploy.yml (3)
3-7: 建议限定标签触发模式
当前on.push.tags: ['*']会对所有标签进行部署，可能引发误触。建议使用严格的语义版本格式（例如v*.*.*），以只对发布版本的标签触发构建。
23-25: 确认生成 package-lock.json 步骤的必要性
如果仓库已包含package-lock.json，npm i --package-lock-only --ignore-scripts这一步只是重新生成锁文件，可考虑移除以加快 CI；如因特殊需求保留，请在注释中说明原因。
32-33: 升级 peaceiris/actions-gh-pages Action 版本（可选）
建议将peaceiris/actions-gh-pages@v3升级到最新的@v4版本，以获取新功能和安全修复：- uses: peaceiris/actions-gh-pages@v3 + uses: peaceiris/actions-gh-pages@v4🧰 Tools
🪛 actionlint (1.7.7)
33-33: the runner of "peaceiris/actions-gh-pages@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/site-deploy.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/site-deploy.yml
16-16: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
19-19: the runner of "actions/setup-node@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
33-33: the runner of "peaceiris/actions-gh-pages@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
Summary by CodeRabbit
新功能
文档
重构
依赖升级
杂项