Fix getContainer make container empty #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikogu
commented
Jan 11, 2018
| if (getContainer) { | ||
| div = getContainer(); | ||
| const root = getContainer(); | ||
| root.appendChild(div); |
There was a problem hiding this comment.
跟 body 一样，创建一个节点作为容器。
nikogu
commented
Jan 11, 2018
src/Notification.jsx
Outdated
| const root = getContainer(); | ||
| if (root) { | ||
| root.removeChild(div); | ||
| } |
There was a problem hiding this comment.
container.parentNode.removeChild(container);
getContainer() 返回的节点也可能是动态创建的。
|
测试 |
|
我再补充个销毁的好了 |
|
@yesmeck done！~ |
|
npm @benjycui @paranoidjk 才有权限 |
|
@yesmeck 给你加了 |
|
@nikogu 给你加了 |
|
ok |
|
@yesmeck @paranoidjk @benjycui npm 包有权限了，发了，但是 github 没权限 tag 没打上，你们谁加我下权限或者打个 3.0.1 的 tag（用当前 master 分支） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design#8906