feat: add reorder ability to ListItemField #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
along side with sort by up down buttons, a user could sort the list items by dragging them to where in the list he wants to have them |
…well as for the delete button, set buttons layout to be closer to each other, fix lint error
|
@macrozone that is a good point, i have improved this ui a bit more, by reducing the icon buttons padding to have the buttons showing closer to each other. also in case that there is less then 2 elements, the sorting feature is disabled. |
|
that looks fantastic! |
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to reorder ListItemField items complementary to the ListDelField
Proposed changes
addition of ListSortField, two buttons, with similar logic of ListDelField button that helps user change the order of the items on the list.
Types of changes
On the left side of the ListItemField component, as the delete button is on the right, so to prevent unintended deletions, addition of two buttons that allow a user to reorder the items on the list, either push the item up (if the item not already the first) and down (if the item is not already at the bottom)
Checklist