Use ViewWillAppear for iOS activation #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes reactiveui#778 WillAppear allows activation to take place before the view is displayed. This means that handlers or visual components can get into place and transition into view. Otherwise, DidAppear creates a window of inactivity where an animated view may appear void of activation until it's fully in view.
2 tasks
glennawatson
pushed a commit
that referenced
this pull request
Mar 23, 2019
Use ViewWillAppear for iOS activation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Enhancement.
What is the current behavior? (You can also link to an open issue here)
iOS activation occurs on
ViewDidAppear, meaning there is a slight delay after a view appears before bindings and such are enacted. This results in a short, but jarring delay between the view appearing and the data appearing within the view.What is the new behavior (if this is a feature change)?
iOS activation occur on
ViewWillAppear, meaning bindings and such can be enacted just before the view is shown to the user.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Other information:
This PR builds on, and supersedes #779. There was one outstanding controller that needed to also be switched over, though it was probably added after #779 was opened.