housekeeping: add flags for making visual studio preview and maui optional #821
Conversation
|
We could possibly just add a global "secret" as a environment variable, and make more consistent use of our github actions. Also might be worth adopting this at some point https://docs.github.com/en/actions/learn-github-actions/reusing-workflows
|
|
Guess we need another flag for install preview now as well. |
requiring 17.1 pre which isn't being picked up by the vs update at this point anyway
|
will look at reusable. could then put it in https://github.com/reactiveui/.github to share between the repos that need it? get it working first :) as for flags as you like
|
Codecov Report
@@ Coverage Diff @@
## main #821 +/- ##
==========================================
+ Coverage 74.26% 74.36% +0.10%
==========================================
Files 99 99
Lines 4970 4970
==========================================
+ Hits 3691 3696 +5
+ Misses 1279 1274 -5
Continue to review full report at Codecov.
|
|
status check doesn't seem to like the change to a workflow. is it a simple tweak in the settings? if so and happy to proceed based on the ci yml i'll do the release yml |
|
Seems the status name has been changed. To build build build. |
|
I've created https://github.com/reactiveui/actions-common You have access to that repo Might be a better location for this script
|
|
https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#creating-a-reusable-workflow suggests it needs to be in .github/workflows will try tagging to main |
|
the question of names in each of the bits "build build build" |
|
Yeah I can change it to reference build / build / build, I guess that's a valid workaround although a bit ugly. |
|
Once that is done I'll get some help updating all the other repos to use this script where practical. RxUI will likely be the tricky one due to multiple sln, might need to move those additional sln into different folder just to make our lives easier. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
CI change
closes #797
What is the current behavior?
Always opt for running vs2022 preview and maui check
What is the new behavior?
allows moving to stable\preview versions of both (once maui in vs properly)
What might this PR break?
n/a
Please check if the PR fulfills these requirements
Other information: