8000 Add support for controlling how string body parameters are serialized by clairernovotny · Pull Request #425 · reactiveui/refit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for controlling how string body parameters are serialized #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2018
Merged

Add support for controlling how string body parameters are serialized #425

merged 2 commits into from
Jan 29, 2018

Conversation

clairernovotny
Copy link
Member

@clairernovotny clairernovotny requested a review from bennor January 29, 2018 22:20
bennor
bennor reviewed Jan 29, 2018
View reviewed changes
Refit/RequestBuilderImplementation.cs
if (paramList[i] is HttpContent httpContentParam)
{
ret.Content = httpContentParam;
}
else if (streamParam != null)
else if (paramList[i] is Stream streamParam)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

bennor
bennor approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor
@bennor bennor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think it makes things a fair bit clearer too.

@clairernovotny clairernovotny merged commit 45b3ce8 into master Jan 29, 2018
@clairernovotny clairernovotny deleted the string-body branch January 29, 2018 23:02
@bennor bennor mentioned this pull request Jan 29, 2018
Closed
fedemkr added a commit to fedemkr/refit that referenced this pull request Mar 19, 2019
@fedemkr
Update docs because of reactiveui#425
f083efd 
Explained how a parameter of type string can be sent as a `StringContent` in `Body` given the PR reactiveui#425
@fedemkr fedemkr mentioned this pull request Mar 19, 2019
Merged
2 tasks
clairernovotny pushed a commit that referenced this pull request Mar 31, 2019
Merge pull request #638 from fedemkr/patch-1
82b093e 
Update docs because of #425
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bennor bennor bennor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clairernovotny @bennor
0