Updated documentation for use of delegating handler with HttpClientFactory #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a Readme update
What is the current behavior?
It seems that delegating handlers actually behave differently with HttpClientFactory. I did get an exception if I followed the existing documentation. I think
AddHttpMessageHandlerdoes some magic behind the scenes like assigning InnerHandler via the public property itself to preserve the chain, and thennew HttpClientHandleras the Inner Handler messes with it and we get an exception.It's probably still a correct thing to do without
HttpClientFactoryand perhaps it is also dependent on dotnet version? I got an exception in 3.1 at least.The documentation here suggests the same (no inner handler).
What is the new behavior?
Inner handler is removed from the parameters
What might this PR break?
Only documentation file is changed
Please check if the PR fulfills these requirements
Other information: