8000 Add logic to emit #nullable in the generated files if required by clairernovotny · Pull Request #1069 · reactiveui/refit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add logic to emit #nullable in the generated files if required #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

clairernovotny
Copy link
Member

@sharwell I'd appreciate a code review

Copy link
Contributor
@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good 👍

Would like to see tests, if for no other reason than knowing it supports this case. 😄

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>
@clairernovotny clairernovotny merged commit a0f47f7 into main Feb 10, 2021
@clairernovotny clairernovotny deleted the nullable branch February 10, 2021 01:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0