Add MemberNotNullWhen annotation for Content / HasContent pair #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

ChrisPulman merged 5 commits into reactiveui:main from hansmbakker:feature/nullability-apiexception-content-hascontent

Aug 17, 2024

Merged

Add MemberNotNullWhen annotation for Content / HasContent pair #1779

Update API Tests

Annotations

12 warnings

The following actions use a deprecated Node.js version and will be forced to run on node20: glennawatson/coverlet-msbuild@v2.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Codecov: Failed to properly create commit: The process 'D:\a\_actions\codecov\codecov-action\v4\dist\codecov.exe' failed with exit code 1

InterfaceStubGenerator.Shared/InterfaceStubGenerator.cs#L118

In externally visible method 'void InterfaceStubGenerator.GenerateInterfaceStubs<TContext>(TContext context, Action<TContext, Diagnostic> reportDiagnostic, Action<TContext, string, SourceText> addSource, CSharpCompilation compilation, string? refitInternalNamespace, ImmutableArray<MethodDeclarationSyntax> candidateMethods, ImmutableArray<InterfaceDeclarationSyntax> candidateInterfaces)', validate parameter 'reportDiagnostic' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)

InterfaceStubGenerator.Shared/InterfaceStubGenerator.cs#L107

In externally visible method 'void InterfaceStubGenerator.GenerateInterfaceStubs<TContext>(TContext context, Action<TContext, Diagnostic> reportDiagnostic, Action<TContext, string, SourceText> addSource, CSharpCompilation compilation, string? refitInternalNamespace, ImmutableArray<MethodDeclarationSyntax> candidateMethods, ImmutableArray<InterfaceDeclarationSyntax> candidateInterfaces)', validate parameter 'compilation' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)

InterfaceStubGenerator.Shared/InterfaceStubGenerator.cs#L224

In externally visible method 'void InterfaceStubGenerator.GenerateInterfaceStubs<TContext>(TContext context, Action<TContext, Diagnostic> reportDiagnostic, Action<TContext, string, SourceText> addSource, CSharpCompilation compilation, string? refitInternalNamespace, ImmutableArray<MethodDeclarationSyntax> candidateMethods, ImmutableArray<InterfaceDeclarationSyntax> candidateInterfaces)', validate parameter 'addSource' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)

InterfaceStubGenerator.Shared/InterfaceStubGenerator.cs#L92

Member 'GenerateInterfaceStubs' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)

InterfaceStubGenerator.Shared/InterfaceStubGenerator.cs#L878

Type 'SyntaxReceiver' can be sealed because it has no subtypes in its containing assembly and is not externally visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1852)

Refit/CamelCaseUrlParameterKeyFormatter.cs#L8

Missing XML comment for publicly visible type or member 'CamelCaseUrlParameterKeyFormatter.Format(string)'

Refit/EnumerableExtensions.cs#L24

The type 'TKey' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'TKey' doesn't match 'notnull' constraint.

Refit/RestMethodParameterInfo.cs#L5

Missing XML comment for publicly visible type or member 'RestMethodParameterInfo'

Refit/EnumerableExtensions.cs#L26

The type 'TKey' cannot be used as type parameter 'TKey' in the generic type or method 'Dictionary<TKey, TValue>'. Nullability of type argument 'TKey' doesn't match 'notnull' constraint.

Refit/RestMethodParameterInfo.cs#L7

Missing XML comment for publicly visible type or member 'RestMethodParameterInfo.RestMethodParameterInfo(string, ParameterInfo)'

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add MemberNotNullWhen annotation for Content / HasContent pair #1779

Uh oh!

Uh oh!

Add MemberNotNullWhen annotation for Content / HasContent pair #1779

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...