8000 Enable Refit on iOS via code generation by anaisbetts · Pull Request #38 · reactiveui/refit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable Refit on iOS via code generation #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 66 commits into from
Oct 12, 2014
Merged

Enable Refit on iOS via code generation #38

merged 66 commits into from
Oct 12, 2014

Conversation

anaisbetts
Copy link
Member

This is on-hold until Xamarin fixes the iOS build system on OS X so that we can add pre-build commands

This PR 🔥s Castle.Core's dynamic proxies and replaces them with code generation via analysing the existing source files with Roslyn and running a pre-build task which generates a new "RefitStubs.cs" code file.

TODO:

  • Find a more reliable way for InterfaceStubGenerator to find the project directory (probably by doing hacky things)

@ghuntley
Copy link
Member

Whom do we need to lynch at Xamarin to get this hotness integrated? ♨️ 🍰

@anaisbetts
Copy link
Member Author

Hah! I filed a bug with their support team, hopefully @chrisntr that @conceptdev gets @jamesmontemagno their @zgramana attention :cough: @migueldeicaza, so that we can get xbuild for Xamarin.iOS and move from the old mdtool-based build system

@migueldeicaza
Copy link

Paul, we have been working on a migration to xbuild for iOS, but the devil is in the details :-(

We want to move as much as the next guy, but needs some work until it is finished.

@anaisbetts
Copy link
Member Author

@migueldeicaza Totally understand! Just wanted to add my +1

@anaisbetts anaisbetts mentioned this pull request Jun 19, 2014
Closed
@cfraz89
Copy link
cfraz89 commented Jul 2, 2014

Hi paul,
I'd like to use refit for my organisation's project. Unfortunately we have to support iOS too. Minus the build system issue, is this branch functional on iOS? We're using gradle around the Xamarin build systems, so running the codegen pre-build wouldn't be an issue for us.

I'd be happy to put in any work required to get this going on iOS.

@anaisbetts
Copy link
Member Author

I'd like to use refit for my organisation's project. Unfortunately we have to support iOS too. Minus the build system issue, is this branch functional on iOS?

@cfraz89 Yeah, the tests show how to rig it up in the build - it works in the csproj, but you have to manually set it up by hand. https://github.com/paulcbetts/refit/blob/roslyn-codegen/Refit-Tests/Refit-Tests-iOS.csproj#L121-127 are the relevant lines that make it work

@anaisbetts anaisbetts mentioned this pull request Jul 7, 2014
Closed
@cfraz89
Copy link
cfraz89 commented Jul 15, 2014

@paulcbetts Thanks, got it working. Running the generator from out of the iOS csproj wouldn't work however, even in the fresh Refit-Tests project. mdtool just seemed to ignore the section...

However have got it going integrated into our build system, is working nicely. Ty, would totally recommend releasing as a beta or whatnot in its current state.

Sorry, something went wrong.

@SimonSimCity
Copy link

Any updates on that one?
Does building the library work at all on OS X?

@anaisbetts
Copy link
Member Author

@SimonSimCity No updates. The library as-is works great on every other platform, including OS X.

@anaisbetts anaisbetts mentioned this pull request Sep 23, 2014
Closed
@anaisbetts
Copy link
Member Author

This should totally work on the new unified Xamarin.iOS now, gonna pick this up again 🔜

@ghuntley
Copy link
Member

Hot stuff <3

On 30 Sep 2014, at 4:18 am, Paul Betts notifications@github.com wrote:

This should totally work on the new unified Xamarin.iOS now, gonna pick this up again

—
Reply to this email directly or view it on GitHub.

@anaisbetts anaisbetts changed the title [ON HOLD] Enable Refit on iOS via code generation Enable Refit on iOS via code generation Oct 12, 2014
anaisbetts pushed a commit that referenced this pull request Oct 12, 2014
Merge pull request #38 from paulcbetts/roslyn-codegen
8565426 
Enable Refit on iOS via code generation
@anaisbetts anaisbetts merged commit 8565426 into master Oct 12, 2014
@anaisbetts anaisbetts deleted the roslyn-codegen branch October 12, 2014 03:30
@ghuntley
Copy link
Member

:shipit:

@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anaisbetts @ghuntley @migueldeicaza @cfraz89 @SimonSimCity
0