Improve memory consumption for failed connection attempts #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the reference, the one failing test case covers the problem addressed in reactphp/promise-timer#33 and reactphp/promise#117 (and also indirectly covered in reactphp/promise#118, but for PHP 7+ only), so that this should be fixed once these PRs are in. I'll update this PR accordingly then. |
This was referenced May 5, 2018
6d3b47f to
8ff349a
Compare
|
Updated to resolve merge conflict now that #162 is in. The one test case will still fail until reactphp/promise-timer#33 is in. |
04e5542 to
6f7690e
Compare
|
Updated and removed WIP marker now that https://github.com/reactphp/promise/releases/tag/v2.6.0 and https://github.com/reactphp/promise-timer/releases/tag/v1.4.0 have been released, this is now ready |
jsor
approved these changes
Jun 11, 2018
WyriHaximus
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging some very odd memory issues in a live application, I noticed that this component shows some unexpected memory consumption and memory would not immediately be freed as expected. Let's not call this a "memory leak", because memory was eventually freed, but this clearly caused some unexpected and significant memory growth.
Parts of this issue have been resolved with #159 already which raised the discussion to address these issues in the upstream react/promise component. A number of patches have been filed via reactphp/promise#113, reactphp/promise#115, reactphp/promise#116, reactphp/promise#117, reactphp/promise#118 and reactphp/promise-timer#33.
I'm marking this PR as WIP because the referenced changes are yet to be released as part of react/promise v2.6.0. Once this release is out, I'll update the version reference and this should be ready to be shipped.
This PR actually includes a number of tests that show how garbage memory references are no longer an issue in any supported PHP version and how failed connection attempts no longer cause any such references on their own (unlike the previous changes in #159 this means that we can now test this and this requires no effort on the consumer side anymore).