Add Evm integration tests #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facs95
reviewed
May 20, 2025
| @@ -21,7 +25,7 @@ import ( | |||
| // returns the current testing context | |||
| type EVMTestSuite struct { | |||
| suite.Suite | |||
| network network.Network | |||
| network *network.UnitTestNetwork | |||
There was a problem hiding this comment.
These are integration tests. The name of the file is evm_integration_tests. So in Integration Tests we should not use UnitTestNetwork. This should only be used for Unit tests where accessing the App is valid. The integration test util were designed so the App is not accesible and a more "pure" integration is followed.
facs95
reviewed
May 20, 2025
facs95
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5CB2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.