Delete some obsolete cruft #5662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SSE/AVX code was written in 2012 and mostly hasn't been touched since then. In the time since then, runtime checking for SSE4.2 support has become pointless (CPUs supporting it were first released in 2008, so it was somewhat recent in 2012 and now is not at all recent), and we never actually wrote anything which requires AVX. There was also some SSE code which has been disabled since 2012. set_string_compare_method() and everyhing related to it has never actually been used by any SDK, and is not really the correct solution to the problem anyway. The encryption code used `ssize_t` in a few places because it was originally written to use `pread` and friends, but the functions it now calls use `size_t` and `ssize_t` doesn't exist on Windows. The use of ssize_t in the Windows networking code was simply incorrect; the winsock functions return `int`.
michael-wb
pushed a commit
that referenced
this pull request
Mar 22, 2023
This reverts commit cbe560a.
|
Restoring branch since it seems #6406 may rely on some of these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSE/AVX code was written in 2012 and mostly hasn't been touched since then. In the time since then, runtime checking for SSE4.2 support has become pointless (CPUs supporting it were first released in 2008, so it was somewhat recent in 2012 and now is not at all recent), and we never actually wrote anything which requires AVX. There was also some SSE code which has been disabled since 2012.
set_string_compare_method() and everything related to it has never actually been used by any SDK, and is not really the correct solution to the problem anyway.
The encryption code used
ssize_tin a few places because it was originally written to usepreadand friends, but the functions it now calls usesize_tandssize_tdoesn't exist on Windows. The use of ssize_t in the Windows networking code was simply incorrect; the winsock functions returnint.