8000 add support for shallow notifications by JacobOscarGunnarsson · Pull Request #6122 · realm/realm-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add support for shallow notifications #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 9, 2023
Merged

add support for shallow notifications #6122

merged 11 commits into from
Jan 9, 2023

Conversation

JacobOscarGunnarsson
Copy link
Contributor

currently the tests are not exhaustive enough, but I'll add it continuously, this branch is tied to this PR in realm .NET where we're trying to add notifications that doesn't react to nested property changes for efficiencies sake

fealebenpae
fealebenpae reviewed Dec 14, 2022
View reviewed changes
Copy link
Member
@fealebenpae fealebenpae left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But yes, more tests are called for. Please add a more detailed PR description of what this change does, and also update the changelog.

@fealebenpae fealebenpae requested a review from tgoyne December 14, 2022 15:10
@fealebenpae
Copy link
Member

@tgoyne can you please take a look as well?

tgoyne
tgoyne reviewed Dec 14, 2022
View reviewed changes
Copy link
Member
@tgoyne tgoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable approach to me.

@JacobOscarGunnarsson JacobOscarGunnarsson marked this pull request as ready for review December 15, 2022 15:56
@cla-bot cla-bot bot added the cla: yes label Dec 15, 2022
JacobOscarGunnarsson
JacobOscarGunnarsson commented Dec 15, 2022
View reviewed changes
cmelchior
cmelchior reviewed Dec 15, 2022
View reviewed changes
@JacobOscarGunnarsson
Copy link
Contributor Author

not sure if the problem in core factor is something I should deal with? It only points me to the dictionary.cpp but I don't believe it's necessarily more complicated than the content of any other tests here?

@JacobOscarGunnarsson JacobOscarGunnarsson mentioned this pull request Dec 20, 2022
Closed
@tgoyne
Copy link
Member
tgoyne commented Dec 20, 2022

Cyclomatic complexity is a sort of flawed metric. and how tests are defined with Catch2 (with a lot of independent test sections within a single function) is a textbook example of something that it considers very bad. It's worth taking a second look at the code when that warning pops up to see if the function needs to be refactored, but it's fine to then ignore it if the code is fine.

tgoyne
tgoyne reviewed Dec 21, 2022
View reviewed changes
@JacobOscarGunnarsson JacobOscarGunnarsson merged commit 25f7e06 into master Jan 9, 2023
@JacobOscarGunnarsson JacobOscarGunnarsson deleted the jg/shallow_notifications_dotnet branch January 9, 2023 13:41
@tgoyne tgoyne mentioned this pull request Jan 19, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmelchior cmelchior cmelchior left review comments

@tgoyne tgoyne tgoyne left review comments

@fealebenpae fealebenpae fealebenpae approved these changes

@nirinchev nirinchev Awaiting requested review from nirinchev

@papafe papafe Awaiting requested review from papafe

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JacobOscarGunnarsson @fealebenpae @tgoyne @cmelchior
0