8000 Make log level threshold atomic and shared by michael-wb · Pull Request #6198 · realm/realm-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Make log level threshold atomic and shared #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 19, 2023
Merged

Make log level threshold atomic and shared #6198

merged 5 commits into from
Jan 19, 2023

Conversation

michael-wb
Copy link
Contributor
@michael-wb michael-wb commented Jan 15, 2023 •
edited
Loading

What, How & Why?

Update the log level threshold to be atomic (thread-safe) and shared across linked instances, such as for the PrefixLogger and ThreadSafeLogger that take a base_logger base reference. This allows the level threshold to be set by the base logger or any linked instances and the new value will be used by all logger instances in the chain. Before these changes, the level threshold was cached by the linked instances and any updates would not propagate to the other loggers in the chain.

Also, the test_logger.hpp file was not used by the code base and was removed to prevent confusion.

Fixes #6009

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Jan 15, 2023
@sync-by-unito sync-by-unito bot mentioned this pull request Jan 15, 2023
Closed
jbreams
jbreams reviewed Jan 17, 2023
View reviewed changes
@michael-wb michael-wb force-pushed the mwb/atomic-log-level branch from 2580e74 to 5c537bb Compare January 18, 2023 02:03
@michael-wb michael-wb self-assigned this Jan 18, 2023
@michael-wb michael-wb mentioned this pull request Jan 18, 2023
Merged
3 tasks
@michael-wb michael-wb merged commit 81b035c into master Jan 19, 2023
@michael-wb michael-wb deleted the mwb/atomic-log-level branch January 19, 2023 13:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbreams jbreams jbreams approved these changes

@danieltabacaru danieltabacaru danieltabacaru approved these changes

Assignees

@michael-wb michael-wb

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Logger level threshold to be atomic
3 participants
@michael-wb @jbreams @danieltabacaru
0