8000 Remove File::is_removed by fealebenpae · Pull Request #6222 · realm/realm-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove File::is_removed #6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2023
Merged

Remove File::is_removed #6222

merged 3 commits into from
Jan 23, 2023

Conversation

fealebenpae
Copy link
Member
@fealebenpae fealebenpae commented Jan 21, 2023 •
edited
Loading

What, How & Why?

Apparently this method is no longer used and was marked for deletion.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@fealebenpae fealebenpae requested a review from jedelbo January 21, 2023 19:07
@fealebenpae fealebenpae self-assigned this Jan 21, 2023
@cla-bot cla-bot bot added the cla: yes label Jan 21, 2023
@bmunkholm
Copy link
Contributor
bmunkholm commented Jan 23, 2023 •
edited
Loading

If is_removed is removed, then it should return true always as its now removed but how can it do that when it is removed?

@jedelbo
Copy link
Contributor
jedelbo commented Jan 23, 2023

If is_removed is removed, then it should return true always as its now removed but how can it do that when it is removed?

@bmunkholm perhaps you should lie down a bit.

@fealebenpae fealebenpae merged commit f34a371 into master Jan 23, 2023
@fealebenpae fealebenpae deleted the yg/file-is_removed branch January 23, 2023 13:48
@ianpward
Copy link
Contributor

If is_removed is removed, then it should return true always as its now removed but how can it do that when it is removed?

@bmunkholm perhaps you should lie down a bit.

😂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jedelbo jedelbo jedelbo approved these changes

Assignees

@fealebenpae fealebenpae

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fealebenpae @bmunkholm @jedelbo @ianpward
0