8000 Make changeset printer util able to parse sync logs by jbreams · Pull Request #6375 · realm/realm-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make changeset printer util able to parse sync logs #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 27, 2023
Merged

Make changeset printer util able to parse sync logs #6375

merged 7 commits into from
Mar 27, 2023

Conversation

jbreams
Copy link
Contributor
@jbreams jbreams commented Mar 10, 2023 •
edited
Loading

What, How & Why?

This makes it so you can feed trace-level sync logs into the realm-print-changeset utility and also fixes up the argument handling and a few other small refactors to that utility. Now if you get a log file from a customer with hex-encoded changesets in the trace level logging, you can pass it directly into this utility and it will print the log file back out but with decoded changesets where the hex/base64 blobs were in the input.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Mar 10, 2023
@jbreams jbreams marked this pull request as draft March 21, 2023 15:12
@jbreams jbreams marked this pull request as ready for review March 21, 2023 18:44
danieltabacaru
danieltabacaru approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator
@danieltabacaru danieltabacaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚢 🇮🇹

michael-wb
michael-wb approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor
@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! - I noticed our evergreen parsley logs don't have the changesets binary anymore... maybe it's only for certain variants? or maybe it was never really there and I'm imagining things?

@jbreams jbreams merged commit ea7b5d3 into master Mar 27, 2023
@jbreams jbreams deleted the jbr/fix_up_changeset_printer_util branch March 27, 2023 20:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danieltabacaru danieltabacaru danieltabacaru approved these changes

@michael-wb michael-wb michael-wb approved these changes

Assignees

@jbreams jbreams

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbreams @danieltabacaru @michael-wb
0