Fix missing dependencies on install #6479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a7671a to
c538ca2
Compare
fealebenpae
approved these changes
Apr 6, 2023
michael-wb
approved these changes
Apr 6, 2023
| ) | ||
|
|
||
| set(NOINST_HEADERS | ||
| trigger.hpp | ||
| set(SYNC_NETWORK_INSTALL_HEADERS | ||
| network/default_socket.hpp |
There was a problem hiding this comment.
Unless you really need this file (i.e. can't compile without it), I would recommend moving this one to the NOINST_HEADERS section, since it is intended to only be used internally.
There was a problem hiding this comment.
because sync_client.hpp uses that header we can't do that unfortunately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build would not succeed when consuming core as an installed dependancy due to missing headers on install.
☑️ ToDos