Add unit test for MigrationStore #6495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you hit the same issue ( |
| REQUIRE(table_sub->name == sub_name); | ||
| } | ||
|
|
||
| TEST_CASE("Migration store", "[flx][migration]") { |
There was a problem hiding this comment.
since these are not integration tests and are logically separated from the rest of the tests, maybe they should be in their own file (i.e, migration_store_test.cpp)
| @@ -116,7 +116,8 @@ bool MigrationStore::is_migrated() | |||
| void MigrationStore::complete_migration() | |||
| { | |||
| // Ensure the migration table has been initialized | |||
| REALM_ASSERT(load_data()); | |||
| bool loaded = load_data(); | |||
kmorkos
approved these changes
Apr 13, 2023
jbreams
approved these changes
Apr 13, 2023
|
🚢 🇮🇹 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been appl
2C12
ied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Added unit test for the MigrationStore class to the flx_migration object store tests.
#6392
☑️ ToDos
[ ] C-API, if public C++ API changed.