remove clang-format from Jenkins CI #6564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-wb
approved these changes
May 3, 2023
There was a problem hiding this comment.
Looks good - let's coordinate this merge with the #6563 so they go in around the same time.
nicola-cab
approved these changes
May 3, 2023
jedelbo
approved these changes
May 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely solely on the Evergreen lint check now which also runs clang-format.
The Evergreen lint check and the Jenkins format check are running slightly different versions of clang-format which means that it is impossible for some code changes to pass CI because each versions has a different interpretation of what is correctly formatted code.
Since we intend to eventually move off of Jenkins, I will remove the format check there.
Related to #6563 where Evergreen's clang-format is updated.