8000 Fix building with non-beta Xcode 15 by tgoyne · Pull Request #7055 · realm/realm-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix building with non-beta Xcode 15 #7055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix building with non-beta Xcode 15 #7055

merged 2 commits into from
Oct 30, 2023

Conversation

tgoyne
Copy link
Member
@tgoyne tgoyne commented Oct 12, 2023

The visionOS SDK is currently only available in beta versions of Xcode, so we can't use a major version check to enable it. Instead we need to explicitly enable visionOS when building for it.

@tgoyne tgoyne self-assigned this Oct 12, 2023
@coveralls-official
Copy link
coveralls-official bot commented Oct 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build github_pull_request_281774

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 266 unchanged lines in 23 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.575%
Files with Coverage Reduction New Missed Lines %
src/realm/sync/noinst/client_history_impl.cpp 1 95.39%
test/object-store/audit.cpp 1 99.93%
test/test_dictionary.cpp 1 99.85%
test/test_index_string.cpp 1 94.13%
src/realm/array_string.cpp 2 87.78%
src/realm/db.cpp 2 93.64%
src/realm/sync/network/websocket.cpp 2 75.15%
src/realm/util/logger.cpp 2 86.05%
src/realm/sync/network/network.cpp 3 89.66%
src/realm/sync/noinst/protocol_codec.hpp 3 76.72%
Totals Coverage Status
Change from base Build 1786: 0.01%
Covered Lines: 230609
Relevant Lines: 251826
💛 - Coveralls

@tgoyne
Fix building with non-beta Xcode 15
4170bba 
The visionOS SDK is currently only available in beta versions of Xcode, so we
can't use a major version check to enable it. Instead we need to explicitly
enable visionOS when building for it.
@tgoyne tgoyne force-pushed the tg/xcode-15 branch 2 times, most recently from 096e8fb to 4170bba Compare October 30, 2023 16:26
@tgoyne tgoyne merged commit 56a048d into master Oct 30, 2023
@tgoyne tgoyne deleted the tg/xcode-15 branch October 30, 2023 20:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
@kraenhansen
Copy link
Member

@tgoyne & @ironage could

realm-core/tools/build-apple-device.sh

Line 67 in 56a048d

-D CMAKE_XCODE_ATTRIBUTE_SDKROOT="$sdkroot" \
be reverted now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ironage ironage ironage approved these changes

Assignees

@tgoyne tgoyne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgoyne @kraenhansen @ironage
0