-
Notifications
You must be signed in to change notification settings - Fork 178
Use logging categories #7052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Use logging categories #7052
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -225,23 +225,26 @@ void Replication::set(const Table* t, ColKey col_key, ObjKey key, Mixed value, _ | |
| if (col_key.get_type() == col_type_Link && value.is_type(type_Link)) { | ||
| auto target_table = t->get_opposite_table(col_key); | ||
| if (target_table->is_embedded()) { | ||
| logger->log(util::Logger::Level::trace, " Creating embedded object '%1' in '%2'", | ||
| target_table->get_class_name(), t->get_column_name(col_key)); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, | ||
| " Creating embedded object '%1' in '%2'", target_table->get_class_name(), | ||
| t->get_column_name(col_key)); | ||
| } | ||
| else if (target_table->get_primary_key_column()) { | ||
| auto link = value.get<ObjKey>(); | ||
| auto pk = target_table->get_primary_key(link); | ||
| logger->log(util::Logger::Level::trace, " Linking object '%1' with primary key %2 from '%3'", | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, | ||
| " Linking object '%1' with primary key %2 from '%3'", | ||
| target_table->get_class_name(), pk, t->get_column_name(col_key)); | ||
| } | ||
| else { | ||
| logger->log(util::Logger::Level::trace, " Linking object '%1'[%2] from '%3'", | ||
| target_table->get_class_name(), key, t->get_column_name(col_key)); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, | ||
| " Linking object '%1'[%2] from '%3'", target_table->get_class_name(), key, | ||
| t->get_column_name(col_key)); | ||
| } | ||
| } | ||
| else { | ||
| logger->log(util::Logger::Level::trace, " Set '%1' to %2", t->get_column_name(col_key), | ||
| value.to_string(util::Logger::max_width_of_value)); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Set '%1' to %2", | ||
| t->get_column_name(col_key), value.to_string(util::Logger::max_width_of_value)); | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -253,15 +256,16 @@ void Replication::nullify_link(const Table* t, ColKey col_key, ObjKey key) | |
| select_obj(key); | ||
| m_encoder.modify_object(col_key, key); // Throws | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Nullify '%1'", t->get_column_name(col_key)); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Nullify '%1'", t->get_column_name(col_key)); | ||
| } | ||
| } | ||
|
|
||
| void Replication::add_int(const Table* t, ColKey col_key, ObjKey key, int_fast64_t value) | ||
| { | ||
| do_set(t, col_key, key); // Throws | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Adding %1 to '%2'", value, t->get_column_name(col_key)); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Adding %1 to '%2'", value, | ||
| t->get_column_name(col_key)); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -290,23 +294,24 @@ void Replication::log_collection_operation(const char* operation, const Collecti | |
| if (Table::is_link_type(col_key.get_type()) && value.is_type(type_Link)) { | ||
| auto target_table = m_selected_table->get_opposite_table(col_key); | ||
| if (target_table->is_embedded()) { | ||
| logger->log(util::Logger::Level::trace, " %1 embedded object '%2' in %3%4 ", operation, | ||
| target_table->get_class_name(), path, position); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " %1 embedded object '%2' in %3%4 ", | ||
| operation, target_table->get_class_name(), path, position); | ||
| } | ||
| else if (target_table->get_primary_key_column()) { | ||
| auto link = value.get<ObjKey>(); | ||
| auto pk = target_table->get_primary_key(link); | ||
| logger->log(util::Logger::Level::trace, " %1 object '%2' with primary key %3 in %4%5", operation, | ||
| target_table->get_class_name(), pk, path, position); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, | ||
| " %1 object '%2' with primary key %3 in %4%5", operation, target_table->get_class_name(), | ||
| pk, path, position); | ||
| } | ||
| else { | ||
| auto link = value.get<ObjKey>(); | ||
| logger->log(util::Logger::Level::trace, " %1 object '%2'[%3] in %4%5", operation, | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " %1 object '%2'[%3] in %4%5", operation, | ||
| target_table->get_class_name(), link, path, position); | ||
| } | ||
| } | ||
| else { | ||
| logger->log(util::Logger::Level::trace, " %1 %2 in %3%4", operation, | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " %1 %2 in %3%4", operation, | ||
| value.to_string(util::Logger::max_width_of_value), path, position); | ||
| } | ||
| } | ||
|
|
@@ -337,8 +342,8 @@ void Replication::list_erase(const CollectionBase& list, size_t link_ndx) | |
| select_collection(list); // Throws | ||
| m_encoder.collection_erase(list.translate_index(link_ndx)); // Throws | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Erase '%1' at position %2", get_prop_name(list.get_short_path()), | ||
| link_ndx); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Erase '%1' at position %2", | ||
| get_prop_name(list.get_short_path()), link_ndx); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -347,8 +352,8 @@ void Replication::list_move(const CollectionBase& list, size_t from_link_ndx, si | |
| select_collection(list); // Throws | ||
| m_encoder.collection_move(list.translate_index(from_link_ndx), list.translate_index(to_link_ndx)); // Throws | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Move %1 to %2 in '%3'", from_link_ndx, to_link_ndx, | ||
| get_prop_name(list.get_short_path())); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Move %1 to %2 in '%3'", from_link_ndx, | ||
| to_link_ndx, get_prop_name(list.get_short_path())); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -368,7 +373,8 @@ void Replication::set_erase(const CollectionBase& set, size_t set_ndx, Mixed val | |
| select_collection(set); // Throws | ||
| m_encoder.collection_erase(set_ndx); // Throws | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Erase %1 from '%2'", value, get_prop_name(set.get_short_path())); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Erase %1 from '%2'", value, | ||
| get_prop_name(set.get_short_path())); | ||
| } | ||
| } | ||
|
|
||
|
CEB7
|
@@ -377,7 +383,8 @@ void Replication::set_clear(const CollectionBase& set) | |
| select_collection(set); // Throws | ||
| m_encoder.collection_clear(set.size()); // Throws | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Clear '%1'", get_prop_name(set.get_short_path())); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Clear '%1'", | ||
| get_prop_name(set.get_short_path())); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -407,7 +414,8 @@ void Replication::list_clear(const CollectionBase& list) | |
| select_collection(list); // Throws | ||
| m_encoder.collection_clear(list.size()); // Throws | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Clear '%1'", get_prop_name(list.get_short_path())); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Clear '%1'", | ||
| get_prop_name(list.get_short_path())); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -416,7 +424,7 @@ void Replication::link_list_nullify(const Lst<ObjKey>& list, size_t link_ndx) | |
| select_collection(list); | ||
| m_encoder.collection_erase(link_ndx); | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Nullify '%1' position %2", | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Nullify '%1' position %2", | ||
| m_selected_table->get_column_name(list.get_col_key()), link_ndx); | ||
| } | ||
| } | ||
|
|
@@ -448,7 +456,8 @@ void Replication::dictionary_erase(const CollectionBase& dict, size_t ndx, Mixed | |
| select_collection(dict); | ||
| m_encoder.collection_erase(ndx); | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Erase %1 from '%2'", key, get_prop_name(dict.get_short_path())); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Erase %1 from '%2'", key, | ||
| get_prop_name(dict.get_short_path())); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -457,6 +466,7 @@ void Replication::dictionary_clear(const CollectionBase& dict) | |
| select_collection(dict); | ||
| m_encoder.collection_clear(dict.size()); | ||
| if (auto logger = get_logger()) { | ||
| logger->log(util::Logger::Level::trace, " Clear '%1'", get_prop_name(dict.get_short_path())); | ||
| logger->log(LogCategory::object, util::Logger::Level::trace, " Clear '%1'", | ||
| get_prop_name(dict.get_short_path())); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connection can serve multiple session. Maybe introduce one more category under client for Connection? Otherwise just 'client' would be appropriate i think. @michael-wb what are you thought?