8000 Fix regression on set algebra by jedelbo · Pull Request #7138 · realm/realm-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix regression on set algebra #7138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix regression on set algebra #7138

wants to merge 3 commits into from

Conversation

jedelbo
Copy link
Contributor
@jedelbo jedelbo commented Nov 15, 2023

What, How & Why?

Fixes #7135

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@jedelbo jedelbo requested a review from tgoyne November 15, 2023 11:43
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build github_pull_request_284472

  • 251 of 264 (95.08%) changed or added relevant lines in 6 files are covered.
  • 57 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.678%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/set.hpp 170 174 97.7%
src/realm/set.cpp 14 23 60.87%
Files with Coverage Reduction New Missed Lines %
src/realm/index_string.cpp 1 88.17%
src/realm/obj.cpp 2 91.75%
src/realm/sync/network/websocket.cpp 2 74.23%
src/realm/util/file.cpp 2 82.03%
src/realm/uuid.cpp 2 97.06%
src/realm/object-store/sync/sync_manager.cpp 4 86.58%
src/realm/sync/network/network.cpp 4 89.65%
src/realm/util/assert.hpp 4 87.1%
src/realm/sync/noinst/client_impl_base.cpp 7 85.6%
src/realm/sync/network/default_socket.cpp 13 73.58%
Totals Coverage Status
Change from base Build 1838: 0.01%
Covered Lines: 231236
Relevant Lines: 252226
💛 - Coveralls

@jedelbo
Copy link
Contributor Author
jedelbo commented Nov 17, 2023

Superseded by #7144

@jedelbo jedelbo closed this Nov 17, 2023
@jedelbo jedelbo deleted the je/set-algebra-issue branch January 5, 2024 14:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgoyne tgoyne Awaiting requested review from tgoyne

Assignees

@jedelbo jedelbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in Set::assign_difference in Core 13.23.4
1 participant
@jedelbo
0