8000 [bindgen] remove LinkList by kneth · Pull Request #7307 · realm/realm-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[bindgen] remove LinkList #7307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[bindgen] remove LinkList #7307

wants to merge 3 commits into from

Conversation

kneth
Copy link
Contributor
@kneth kneth commented Feb 2, 2024

What, How & Why?

It might have be added back in during a rebase.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Feb 2, 2024
@kneth kneth requested review from jedelbo and nicola-cab February 2, 2024 11:01
@nicola-cab
Copy link
Member

LGTM once conflicts have been resolved.

<<<<<<< kneth/bindgen/remove-linklist-from-enum
      proxy_config: util::Optional<SyncProxyConfig>
=======
      proxy_config: std::optional<SyncProxyConfig>
>>>>>>> next-major

@kneth kneth mentioned this pull request Feb 2, 2024
Merged
4 tasks
@kneth
Copy link
Contributor Author
kneth commented Feb 2, 2024

Moving to #7308

@kneth kneth closed this Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicola-cab nicola-cab nicola-cab approved these changes

@jedelbo jedelbo Awaiting requested review from jedelbo

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneth @nicola-cab
0