8000 Fix: Resolve code gen in Flutter version 3.27.1 by haitr · Pull Request #1814 · realm/realm-dart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Resolve code gen in Flutter version 3.27.1 #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix: Resolve code gen in Flutter version 3.27.1 #1814

wants to merge 1 commit into from

Conversation

haitr
Copy link
@haitr haitr commented Dec 24, 2024

Problem
It fails to start due to incompatibility issues with updated versions of the analyzer and source_span packages.

Solution
Pin the versions of analyzer and source_span packages.

Changes
Updated pubspec.yaml to fix package versions:

  • analyzer: pinned to version 6.9.0
  • source_span: pinned to version 1.8.0

Copy link
cla-bot bot commented Dec 24, 2024

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @haitr. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@haitr
Copy link
Author
haitr commented Dec 24, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Dec 24, 2024
Copy link
cla-bot bot commented Dec 24, 2024

The cla-bot has been summoned, and re-checked this pull request!

@victorcode1
Copy link

This needs to be resolved

Copy link
Member
@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can only be merged as a short-term fix - pinning the analyzer package like that can cause incompatibilities with other generators that may require different versions.

As far as I understand, the failure reported in #1813 is due to element3 being added to DartType - could we instead of pinning the analyzer, provide a noSuchMethod implementation that returns never? Or does this break in a different way?

@nielsenko nielsenko mentioned this pull request Jan 1, 2025
@nirinchev nirinchev closed this Jan 2, 2025
@haitr
Copy link
Author
haitr commented Jan 6, 2025

@nirinchev Agreed. #1815 came up with the better implementation than mine.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0