8000 Expand hash only in case of single arity by derek-noredink · Pull Request #2 · regateio/aasm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Expand hash only in case of single arity #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Expand hash only in case of single arity #2

wants to merge 1 commit into from

Conversation

derek-noredink
Copy link
@derek-noredink derek-noredink commented Mar 13, 2025 •
edited
Loading

Hey @thiagofm,

I made this pull request to fix the bug that I described here: aasm#857 (comment)

Passes all of the rspec tests, although I couldn't get appraisal working to test with different versions of rails.

Please let me know what you think of this fix.

This was referenced Mar 13, 2025
Closed
Merged
@derek-noredink
Copy link
Author
derek-noredink commented Mar 13, 2025 •
edited
Loading

Well I tested this against our own codebase and turns out that it doesn't actually work for us.

Error
wrong number of arguments (given 1, expected 2)
Stacktrace
./app/models/guided_draft/student_state.rb:343:in `client_sent_latest_versions?'
/nix/store/99hnd22j4g8lrvlmph0nc6ins59bmx78-ruby3.2-aasm-60de9aafb316/lib/ruby/gems/3.2.0/bundler/gems/aasm-temp-60de9aafb316/lib/aasm/core/invokers/literal_invoker.rb:74:in `invoke_with_fixed_arity'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derek-noredink
0