8000 Support local running of "conda-forge-tick --dry-run auto-tick" by chrisburr · Pull Request #3680 · regro/cf-scripts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support local running of "conda-forge-tick --dry-run auto-tick" #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support local running of "conda-forge-tick --dry-run auto-tick" #3680

wants to merge 2 commits into from

Conversation

chrisburr
Copy link
Contributor

Description:

Add support for running the auto-tick command locally.
I also added the option to passing a regex to only run the migrators which are of interest as well as a --no-update-graph to make debugging faster.

If you'd rather not have this PR merged, I don't mind if it's closed, 95% of the work was needed for debugging something else 😄

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

@codecov Codecov
Copy link
codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 75.72%. Comparing base (96385b6) to head (2f10994).

Files with missing lines Patch % Lines
conda_forge_tick/make_migrators.py 9.09% 10 Missing ⚠️
conda_forge_tick/auto_tick.py 22.22% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3680      +/-   ##
==========================================
- Coverage   77.36%   75.72%   -1.65%     
==========================================
  Files         134      134              
  Lines       14814    14825      +11     
==========================================
- Hits        11461    11226     -235     
- Misses       3353     3599     +246

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytausch
Copy link
Contributor
ytausch commented Feb 7, 2025

Thank you!

Let me reference #2815 here, which also adds selecting migrators for auto-tick (but is blocked by outstanding reviews)

@beckermr
Copy link
Contributor
beckermr commented Feb 7, 2025

Yeah I have been slow to review here sorry. Why is one PR so much bigger than the other? This one is tiny and very easy to review.

@ytausch
Copy link
Contributor
ytausch commented Feb 7, 2025 •
edited
Loading

My PR is outdated and eventually builds upon this one: #2813 (which is very short and also includes tests).

The line changes come from the linked PR in between (#2814) which allows to run make-migrators (which is needed for auto-tick) locally too.

If you want to review #2813 (to start clearing up the backlog), I can update it. Was waiting for a review on the integration tests first. (because they also secure these changes)

@chrisburr
Copy link
Contributor Author

What's the prefered plan here? Should I finish this up with tests or shall we go with #2815?

@beckermr
Copy link
Contributor

Thanks for the pr. Let's merge as is and we can combine with other prs later.

@beckermr beckermr enabled auto-merge February 18, 2025 13:48
@beckermr beckermr disabled auto-merge February 18, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisburr @ytausch @beckermr
0