8000 make task names compatible with dcijunit by fredericlepied · Pull Request #680 · redhatci/ansible-collection-redhatci-ocp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

make task names compatible with dcijunit #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make task names compatible with dcijunit #680

wants to merge 1 commit into from
+60 −60

Conversation

fredericlepied
Copy link
Contributor
@fredericlepied fredericlepied 8000 commented May 19, 2025
SUMMARY
ISSUE TYPE
  • Refactor
Tests

Test-Hint: no-check

@fredericlepied fredericlepied requested review from a team as code owners May 19, 2025 10:04
@dcibot
Copy link
Collaborator
dcibot commented May 19, 2025

from change #680:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator
dcibot commented May 19, 2025

from change #680:

  • no check (not a code change)

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 19, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

This update systematically renames Ansible task names across multiple roles by inserting an underscore after "Validate" (and in some cases after "Test" or "Fail"), standardizing naming conventions. No changes were made to the underlying task logic, control flow, or error handling—only the descriptive name strings were updated.

Changes

File(s) Change Summary
roles/acm_hypershift/tasks/main.yml
roles/acm_setup/tasks/main.yml
roles/cluster_compare/tasks/main.yml
roles/hco_setup/tasks/main.yml
roles/mirror_from_directory/tasks/main.yml
roles/mirror_from_directory/tasks/validation.yml
roles/odf_setup/tasks/main.yml
roles/sriov_config/tasks/main.yml		 Task names changed from "Validate requirements" (or similar) to "Validate_ requirements" or respective forms.
roles/chart_verifier/tasks/main.yml
roles/fbc_catalog/tasks/main.yml
roles/opcap_tool/tasks/main.yml
roles/ocp_logging/tasks/pre-run.yml
roles/prune_catalog/tasks/main.yml		 Task names changed from "Validate parameters" (or similar) to "Validate_ parameters" or respective forms.
roles/chart_verifier/tasks/tests.yml
roles/prune_catalog/tasks/main.yml		 Task names changed from "Validate all mandatory tests have passed" and "Validate the pruned index" to include an underscore after "Validate".
roles/create_certification_project/tasks/main.yml Task 8000 name changed from "Validate cert_item to be defined" to "Validate_ cert_item to be defined".
roles/create_pr/tasks/main.yml Task names changed from "Validate the presence of parameters" and "Validate that cert_project_id is provided" to include an underscore.
roles/example_cnf_deploy/tasks/main.yml Task name changed from "Validate Example CNF App" to "Validate_ Example CNF App".
roles/get_logs_from_namespace/tasks/main.yml
roles/jenkins_job_launcher/tasks/main.yml
roles/metallb_setup/tasks/main.yml
roles/sideload_kernel/tasks/main.yml
roles/ztp/setup_cluster_image_set/tasks/main.yml		 Task names changed from "Validate required variables" to "Validate_ required variables".
roles/manage_firewalld_zone/tasks/main.yml Task name changed from "Validate input" to "Validate_ input".
roles/metallb_setup/tasks/pre-requisites.yml Four task names changed to insert an underscore after "Validate" (e.g., "Validate_ parameters are defined").
roles/mirror_images/tasks/main.yml Task name changed from "Validate inputs" to "Validate_ inputs".
roles/mirror_ocp_release/tasks/main.yml Multiple task names changed to insert an underscore after "Validate" in each.
roles/ocp_add_users/tasks/main.yml Task names changed from "Validate input variables" and "Validate users and their roles are valid" to add underscore.
roles/ocp_logging/tasks/main.yml Task name changed from "Validate cluster logging subsystem" to "Validate_ cluster logging subsystem".
roles/odf_setup/tasks/validation.yml Task name changed from "Validate OCS external variables" to "Validate_ OCS external variables".
roles/odf_setup/tasks/tests.yml Task names changed from "Test CephRBD PVC" and "Test CephFS PVC" to "Test_ CephRBD PVC" and "Test_ CephFS PVC".
roles/olm_operator/tasks/main.yml Task name changed from "Validate operator installation" to "Validate_ operator installation".
roles/redhat_tests/tasks/main.yml Task name changed from "Validate if the kubevirt CRD is present" to "Validate_ if the kubevirt CRD is present".
roles/rhoai/tasks/main.yml Task name changed from "Validate operator map is complete" to "Validate_ operator map is complete".
roles/setup_gitea/tasks/main.yml Task name changed from "Validate the input variables" to "Validate_ the input variables".
roles/setup_minio/tasks/main.yml Task name changed from "Validate that a storageclass is provided" to "Validate_ that a storageclass is provided".
roles/setup_netobserv_stack/tasks/main.yml Task name changed from "Validate the NetObservability resources" to "Validate_ the NetObservability resources".
roles/setup_radvd/tasks/pre-requisites.yaml Four task names changed to insert an underscore after "Validate" (e.g., "Validate_ required parameters are defined").
roles/sno_installer/tasks/10_get_oc.yml Task names changed from "Validate that master cache directory exists" and "Validate if cache dir for release exists" to include underscore.
roles/sno_node_prep/tasks/main.yml Task name changed from "Validate disconnected registry" to "Validate_ disconnected registry".
roles/vbmc/tasks/configure.yml Task name changed from "Validate that all VMs are powered on" to "Validate_ that all VMs are powered on".
roles/verify_tests/tasks/parse_junit_file.yml Task names changed from "Fail if file is not present in the log folder" and "Fail if not all test results are as expected for [filename]" to "Test_ if [filename] is present in the log folder" and "Validate_ all test results are as expected for [filename]".

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 81f782b and d221b91.

📒 Files selected for processing (41)
  • roles/acm_hypershift/tasks/main.yml (1 hunks)
  • roles/acm_setup/tasks/main.yml (1 hunks)
  • roles/chart_verifier/tasks/main.yml (1 hunks)
  • roles/chart_verifier/tasks/tests.yml (1 hunks)
  • roles/cluster_compare/tasks/main.yml (1 hunks)
  • roles/create_certification_project/tasks/main.yml (1 hunks)
  • roles/create_pr/tasks/main.yml (2 hunks)
  • roles/example_cnf_deploy/tasks/main.yml (1 hunks)
  • roles/fbc_catalog/tasks/main.yml (2 hunks)
  • roles/get_logs_from_namespace/tasks/main.yml (1 hunks)
  • roles/hco_setup/tasks/main.yml (1 hunks)
  • roles/jenkins_job_launcher/tasks/main.yml (2 hunks)
  • roles/manage_firewalld_zone/tasks/main.yml (1 hunks)
  • roles/metallb_setup/tasks/main.yml (1 hunks)
  • roles/metallb_setup/tasks/pre-requisites.yml (2 hunks)
  • roles/mirror_from_directory/tasks/main.yml (1 hunks)
  • roles/mirror_from_directory/tasks/validation.yml (1 hunks)
  • roles/mirror_images/tasks/main.yml (1 hunks)
  • roles/mirror_ocp_release/tasks/main.yml (2 hunks)
  • roles/ocp_add_users/tasks/main.yml (2 hunks)
  • roles/ocp_logging/tasks/main.yml (1 hunks)
  • roles/ocp_logging/tasks/pre-run.yml (1 hunks)
  • roles/odf_setup/tasks/main.yml (1 hunks)
  • roles/odf_setup/tasks/tests.yml (2 hunks)
  • roles/odf_setup/tasks/validation.yml (1 hunks)
  • roles/olm_operator/tasks/main.yml (1 hunks)
  • roles/opcap_tool/tasks/main.yml (1 hunks)
  • roles/prune_catalog/tasks/main.yml (2 hunks)
  • roles/redhat_tests/tasks/main.yml (1 hunks)
  • roles/rhoai/tasks/main.yml (1 hunks)
  • roles/setup_gitea/tasks/main.yml (1 hunks)
  • roles/setup_minio/tasks/main.yml (1 hunks)
  • roles/setup_netobserv_stack/tasks/main.yml (1 hunks)
  • roles/setup_radvd/tasks/pre-requisites.yaml (2 hunks)
  • roles/sideload_kernel/tasks/main.yml (1 hunks)
  • roles/sno_installer/tasks/10_get_oc.yml (2 hunks)
  • roles/sno_node_prep/tasks/main.yml (1 hunks)
  • roles/sriov_config/tasks/main.yml (1 hunks)
  • roles/vbmc/tasks/configure.yml (1 hunks)
  • roles/verify_tests/tasks/parse_junit_file.yml (2 hunks)
  • roles/ztp/setup_cluster_image_set/tasks/main.yml (1 hunks)
✅ Files skipped from review due to trivial changes (11)
  • roles/sideload_kernel/tasks/main.yml
  • roles/acm_setup/tasks/main.yml
  • roles/redhat_tests/tasks/main.yml
  • roles/acm_hypershift/tasks/main.yml
  • roles/setup_netobserv_stack/tasks/main.yml
  • roles/example_cnf_deploy/tasks/main.yml
  • roles/vbmc/tasks/configure.yml
  • roles/olm_operator/tasks/main.yml
  • roles/ocp_logging/tasks/pre-run.yml
  • roles/metallb_setup/tasks/pre-requisites.yml
  • roles/sno_installer/tasks/10_get_oc.yml
🚧 Files skipped from review as they are similar to previous changes (30)
  • roles/metallb_setup/tasks/main.yml
  • roles/mirror_images/tasks/main.yml
  • roles/chart_verifier/tasks/main.yml
  • roles/manage_firewalld_zone/tasks/main.yml
  • roles/mirror_from_directory/tasks/validation.yml
  • roles/ztp/setup_cluster_image_set/tasks/main.yml
  • roles/setup_gitea/tasks/main.yml
  • roles/mirror_from_directory/tasks/main.yml
  • roles/ocp_logging/tasks/main.yml
  • roles/get_logs_from_namespace/tasks/main.yml
  • roles/jenkins_job_launcher/tasks/main.yml
  • roles/odf_setup/tasks/main.yml
  • roles/sno_node_prep/tasks/main.yml
  • roles/hco_setup/tasks/main.yml
  • roles/mirror_ocp_release/tasks/main.yml
  • roles/chart_verifier/tasks/tests.yml
  • roles/prune_catalog/tasks/main.yml
  • roles/odf_setup/tasks/validation.yml
  • roles/opcap_tool/tasks/main.yml
  • roles/rhoai/tasks/main.yml
  • roles/create_certification_project/tasks/main.yml
  • roles/cluster_compare/tasks/main.yml
  • roles/fbc_catalog/tasks/main.yml
  • roles/sriov_config/tasks/main.yml
  • roles/setup_minio/tasks/main.yml
  • roles/ocp_add_users/tasks/main.yml
  • roles/create_pr/tasks/main.yml
  • roles/odf_setup/tasks/tests.yml
  • roles/verify_tests/tasks/parse_junit_file.yml
  • roles/setup_radvd/tasks/pre-requisites.yaml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Sanity Check (stable-2.17)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/1b74fd6b7fa84597afedaa6959f55c5e

✔️ dci-rpm-build-el8 SUCCESS in 2m 48s
✔️ dci-rpm-build-el9 SUCCESS in 2m 15s

@dcibot
Copy link
Collaborator
dcibot commented May 19, 2025

from change #680:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator
dcibot commented May 19, 2025

from change #680:

  • no check (not a code change)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/7b76eee15aaf40308d1909b34827cf0e

✔️ dci-rpm-build-el8 SUCCESS in 2m 50s
✔️ dci-rpm-build-el9 SUCCESS in 2m 35s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericlepied @dcibot
0