Add static library target and cpack support #851
Conversation
|
Thanks for the PR! I'm currently putting together v1.0.0 so I think this will need to wait until the first dot release. Changing anything involving build systems makes me too nervous right before such a big release 😄 We should be able to include it in 1.0.1 though given (at first glance) that it appears to be backward compatible. |
|
Still planning to merge this? |
|
Yes, apologies. I will get this merged tomorrow. |
|
When I build this in a Windows VM I get a fatal linker error: Build command: Error: I have no issues building |
|
My bad. I had to copy the last commit from a different machine, and the change was so small that I decided to do it by hand, thereby introducing that extra "o" (crypto32 instead of crypt32). Now fixed. Apologies |
|
No worries, thanks for taking a look! I honestly don't know a lot about Windows so didn't realize it was just a typo. 😄 I'll give it another test and then get this merged for you. |
|
Merged, thanks! |
|
@michael-grunder this fixed #742, right? |
|
I think so, thanks for reminding me! |
This will enable builders to use cpack to obtain packages in any of the formats supported by CPack (eg RPM, DEB, and NuGet)