8000 Enable position-independent code, and add PDB files to packages for MSVC builds by masariello · Pull Request #874 · redis/hiredis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable position-independent code, and add PDB files to packages for MSVC builds #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2020
Merged

Enable position-independent code, and add PDB files to packages for MSVC builds #874

merged 3 commits into from
Oct 18, 2020

Conversation

masariello
Copy link
Contributor

Static libraries need this

@masariello masariello changed the title Enable position-independent code Enable position-independent code, and add PDB files to packages for MSVC builds Sep 9, 2020
@masariello
Copy link
Contributor Author

@michael-grunder could this be merged to master please?
Thank you

@michael-grunder
Copy link
Collaborator

This looks ok to me but I'm less familiar with Windows. I'll try to get it merged this weekend

michael-grunder merged commit f44945a into redis:master Oct 18, 2020
@michael-grunder
Copy link
Collaborator

Merged, thanks.

I did notice that we now have a divergence between make and CMake when building static libraries. Make will build libhiredis.a whereas CMake builds libhiredis_static.a. It seems prudent to use the same name unless there is a reason not to.

@masariello masariello deleted the position-independent-code branch October 19, 2020 05:39
@masariello
Copy link
Contributor Author

I don't think that can be done in cmake unfortunately. To build static and dynamic together one has to have different target names and therefore different base filenames. If it can be done then it likely requires quite a bit of twists and turns.

@SpaceIm SpaceIm mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masariello @michael-grunder
0