Minor refactor of CVE-2021-32765 fix. #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yossigo
approved these changes
Oct 10, 2021
Since `hi_calloc` always passes through one of our wrapper functions, we can perform this overflow in the wrapper, and get protection everywhere. Previous commit: 76a7b10 Related vuln ID: CVE-2021-32765 [Full Details](GHSA-hfm9-39pp-55p2)
fb66f1c to
5e17da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
hi_callocis a wrapper that calls the configuredcallocfunction,we can perform this overflow check there, to protect any
hi_calloccall.Previous commit: 76a7b10
Related vuln ID: CVE-2021-32765
Full Details
@yossigo It was pointed out to me that we could incorporate this check within our
hi_callocwrapper itself. Let me know if if you see any issues with the change.