8000 #1231 Resolve by kendamaskareivis · Pull Request #1232 · redis/hiredis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#1231 Resolve #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

#1231 Resolve #1232

wants to merge 3 commits into from

Conversation

kendamaskareivis
Copy link

See #1231

Changes

  • change in hiredis.h headers
  • changes in Cmakelists.txt file

@kendamaskareivis
Update CMakeLists.txt
3654a3f 
Fixed target properties for versioning
@kendamaskareivis
Update hiredis.h
a1f45c6 
Removed dev
@kendamaskareivis
Update CMakeLists.txt [Typo fix]
8c5ab87 
My brain is dysfunctional sorry
@michael-grunder
Copy link
Collaborator

Thanks for the PR. This does improve things in terms of CMake.

The only issue I see is that the change removes any distinction between v1.2.0 proper and the prerelease development branch.

Also the reason we're creating v1.1.0 for v1.2.0 is that v1.2.0 is still API/ABI compatible with v1.1.0 and we were avoiding breaking changes for existing users of v1.1.0

@kendamaskareivis
Copy link
Author

Forgive me if I'm in the wrong here @michael-grunder , but it seems silly to me that feature updates are actually breaking changes, something to me doesn't add up here. Well anyway, I'd hope you'll reconsider this PR.

@michael-grunder
Copy link
Collaborator

Appologies if I wasn't clear, but I will try to get this merged 😄

I just need to make sure we don't break existing code is all.

The hiredis SONAME has been a bit of a sticking point for legacy reasons. You can read some of the discussion around this here.

@uglide
Copy link
Contributor
uglide commented Apr 23, 2025

Superseeded by #1296

@uglide uglide closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kendamaskareivis @michael-grunder @uglide
0