8000 Update minimum CMake version to 3.7 by uglide · Pull Request #1292 · redis/hiredis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update minimum CMake version to 3.7 #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,29 @@ jobs:
HIREDIS_PATH: ${{ github.workspace }}
run: |
make clean && make

test-cmake-version:
name: Test build with CMake ${{ matrix.cmake-version }}
runs-on: ubuntu-latest
strategy:
matrix:
cmake-version: [
'3.7.0', # Minimum version
'3.22.0', # Ubuntu 22.04 LTS
'3.28.0', # Ubuntu 24.04 LTS
'4.0.0' # Latest version
]
steps:
- uses: actions/checkout@v4
- name: Setup CMake
uses: jwlawson/actions-setup-cmake@v2
with:
cmake-version: ${{ matrix.cmake-version }}
- name: Install hiredis dependencies
run: |
sudo apt-get install -y libssl-dev libevent-dev
- name: Build
run: |
mkdir build && cd build
cmake -DENABLE_SSL=ON -DENABLE_SSL_TESTS=ON -DENABLE_ASYNC_TESTS=ON -DENABLE_EXAMPLES=ON ..
make
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CMAKE_MINIMUM_REQUIRED(VERSION 3.0.0)
CMAKE_MINIMUM_REQUIRED(VERSION 3.7.0)

MACRO(getVersionBit name)
SET(VERSION_REGEX "^#define ${name} (.+)$")
Expand Down
Loading
0