8000 Fix building with enabling ssl on cygwin by fd00 · Pull Request #1302 · redis/hiredis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix building with enabling ssl on cygwin #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix building with enabling ssl on cygwin #1302

wants to merge 1 commit into from

Conversation

fd00
Copy link
@fd00 fd00 commented Jun 18, 2025 
$ uname -srvmpio
CYGWIN_NT-10.0-22000-ARM64 3.6.3-1.x86_64 2025-06-05 11:45 UTC x86_64 unknown unknown Cygwin
$ cd /tmp
$ git clone https://github.com/redis/hiredis.git
$ cd hiredis
$ cmake -DENABLE_SSL:BOOL=ON .
$ make
:
[ 83%] Linking C shared library cyghiredis_ssl-1.dll
/usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld: CMakeFiles/hiredis_ssl.dir/ssl.c.o:ssl.c:(.text+0x658): undefined reference to `__redisSetError'
:
(snip)
:
/usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld: CMakeFiles/hiredis_ssl.dir/ssl.c.o:ssl.c:(.rdata$.refptr.hiredisAllocFns[.refptr.hiredisAllocFns]+0x0): undefined reference to `hiredisAllocFns'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/hiredis_ssl.dir/build.make:99: cyghiredis_ssl-1.dll] Error 1
make[1]: *** [CMakeFiles/Makefile2:113: CMakeFiles/hiredis_ssl.dir/all] Error 2
make: *** [Makefile:166: all] Error 2
$

@Copilot Copilot AI review requested due to automatic review settings June 18, 2025 04:15
Copilot
Copilot AI reviewed Jun 18, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the build errors encountered when enabling SSL on Cygwin by updating the linking condition for the hiredis_ssl target.

  • Adjusts the conditional to link the hiredis library when on WIN32 or CYGWIN.
Comments suppressed due to low confidence (1)

CMakeLists.txt:180

  • Consider adding a comment explaining why CYGWIN is grouped with WIN32 for linking hiredis to aid future maintainers.
    IF(WIN32 OR CYGWIN)

@fd00
Copy link
Author
fd00 commented Jun 18, 2025

Sorry I forgot to disable Automatic Copilot code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fd00
0