8000 Default monitors to a monospace font by Methuselah96 · Pull Request #1051 · reduxjs/redux-devtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Default monitors to a monospace font #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2022
Merged

Default monitors to a monospace font #1051

merged 1 commit into from
Jan 24, 2022

Conversation

Methuselah96
Copy link
Member
@Methuselah96 Methuselah96 commented Jan 24, 2022 •
edited
Loading

Fixes #995.

@Methuselah96 Methuselah96 enabled auto-merge (squash) January 24, 2022 04:40
@Methuselah96 Methuselah96 disabled auto-merge January 24, 2022 04:53
@Methuselah96 Methuselah96 force-pushed the use-monospaced-font-for-monitors branch from cb379d3 to 7c677f0 Compare January 24, 2022 18:53
@Methuselah96
Copy link
Member Author
Methuselah96 commented Jan 24, 2022 •
edited
Loading

This PR goes a little bit overboard with making too many things monospace. It seems that ideally there would be some more refactoring of how styling works in the existing monitors to use @redux-devtools/ui which would provide a uniform way to declare which font type to use in different situations. However currently only the slider monitor uses @redux-devtools/ui. Given that this seems like an improvement over the status quo, I'm planning to merge and release this. The work of standardizing our styling approach can be tackled in a future refactor.

Here are some screenshots for reference. The log and chart monitor look fine, but the inspector and RTK Query monitor should not be using monospace when referring to "non-data."

2.x Inspector Monitor:
inspector-old

Inspector Monitor as of this PR:
image

RTK Query Monitor as of this PR:
image

@Methuselah96 Methuselah96 enabled auto-merge (squash) January 24, 2022 19:02
@Methuselah96 Methuselah96 merged commit c8f36e9 into main Jan 24, 2022
@Methuselah96 Methuselah96 deleted the use-monospaced-font-for-monitors branch January 24, 2022 19:19
luotaoyeah pushed a commit to luotaoyeah/redux-devtools that referenced this pull request Apr 19, 2022
@Methuselah96 @luotaoyeah
Default monitors to a monospace font (reduxjs#1051)
638C 2b27eb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback on new v3.0 UI
1 participant
@Methuselah96
0